fix(iap): address code review defects in freemium/IAP change
Fixes 9 of 10 review findings (10th requires a manual Play Console step, no code change): 1. app.dart/banner_anuncio_superior.dart: move the top SafeArea inside BannerAnuncioSuperior so it only reserves status-bar height when an ad actually renders, restoring edge-to-edge layout for premium and free-unloaded users. 2. servicio_anuncios.dart: bound every interstitial await (load, presentation, and the injected implementation itself) with injectable timeouts so a callback that never fires can no longer hang a caller. 3. estado_entitlement.dart/hoja_premium.dart: expose a typed resultadoUsuario signal for purchase/restore failures and restore-found-nothing, with dedicated localized messages (compraError, restauracionSinCompras) across all 13 locales -- never the raw developer/exception string. 4. main.dart/servicio_consentimiento.dart: add a GDPR/UMP consent flow (ConsentInformation/ConsentForm) that gates Mobile Ads SDK init on canRequestAds(); premium users never see a consent form; failures degrade to no ads instead of crashing or blocking startup. 6. servicio_anuncios.dart: track real ad presentation (onAdShowedFullScreenContent) so a failed-to-show interstitial no longer consumes a session cap slot. 7. banner_anuncio_superior.dart: add an explicit load-attempted guard so repeated didChangeDependencies (e.g. entitlement notifyListeners during a purchase) can only ever trigger one banner load attempt. 8. servicio_anuncios.dart: make esPremium a required constructor parameter, matching the hardened contract already applied to EstadoAlarmas/EstadoGrabacion/EstadoRadio. 9. hoja_premium.dart: add a dedicated premiumActivo localized string instead of reusing the equalizer's equalizerActive translation, across all 13 locales. All fixes implemented RED-first (failing test before production code). Full suite: 1261 passed, 2 pre-existing skips, 0 failures. flutter analyze: 5 pre-existing issues only, 0 new. [version set]
This commit is contained in:
@@ -1,11 +1,34 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:pluriwave/estado/estado_entitlement.dart';
|
||||
import 'package:pluriwave/servicios/servicio_anuncios.dart';
|
||||
import 'package:pluriwave/servicios/servicio_compras.dart';
|
||||
import 'package:pluriwave/widgets/banner_anuncio_superior.dart';
|
||||
import 'package:provider/provider.dart';
|
||||
import 'package:shared_preferences/shared_preferences.dart';
|
||||
|
||||
/// Fake [PuertoCompras] (mirrors `app_test.dart`'s own fake): lets a test
|
||||
/// drive [EstadoEntitlement]'s purchase-stream `notifyListeners()` calls
|
||||
/// without touching `in_app_purchase`.
|
||||
class _PuertoComprasFalso implements PuertoCompras {
|
||||
final _eventos = StreamController<EventoCompra>.broadcast();
|
||||
|
||||
@override
|
||||
Stream<EventoCompra> get eventos => _eventos.stream;
|
||||
|
||||
@override
|
||||
Future<void> comprar() async {}
|
||||
|
||||
@override
|
||||
Future<void> restaurar() async {}
|
||||
|
||||
void emitir(EventoCompra evento) => _eventos.add(evento);
|
||||
|
||||
Future<void> dispose() => _eventos.close();
|
||||
}
|
||||
|
||||
/// Ad-display spec "Persistent Top Banner, Never Overlapping Content": the
|
||||
/// banner is entitlement-aware and reserves layout via a `Column`
|
||||
/// (`SizedBox.shrink()` collapses it to zero footprint) — never a `Stack`
|
||||
@@ -72,4 +95,66 @@ void main() {
|
||||
expect(tester.getSize(banner).height, 0);
|
||||
expect(find.text('contenido'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('didChangeDependencies repetido (ej. notifyListeners de '
|
||||
'EstadoEntitlement durante una compra en curso) dispara como mucho UN '
|
||||
'intento de carga real (FIX 7, code review)', (tester) async {
|
||||
final compras = _PuertoComprasFalso();
|
||||
addTearDown(compras.dispose);
|
||||
var intentosDeCarga = 0;
|
||||
|
||||
await tester.pumpWidget(
|
||||
MultiProvider(
|
||||
providers: [
|
||||
ChangeNotifierProvider<EstadoEntitlement>(
|
||||
create: (_) => EstadoEntitlement(prefs: null, compras: compras),
|
||||
),
|
||||
Provider<ServicioAnuncios>(
|
||||
create: (_) => ServicioAnuncios(esPremium: () => false),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(
|
||||
home: Scaffold(
|
||||
body: Column(
|
||||
children: [
|
||||
BannerAnuncioSuperior(
|
||||
alIntentarCargar: () => intentosDeCarga++,
|
||||
),
|
||||
const Expanded(child: Center(child: Text('contenido'))),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
await tester.pump();
|
||||
await tester.pump(const Duration(milliseconds: 50));
|
||||
|
||||
expect(
|
||||
intentosDeCarga,
|
||||
1,
|
||||
reason: 'el primer didChangeDependencies debe intentar UNA carga',
|
||||
);
|
||||
|
||||
// Cada uno de estos eventos hace que EstadoEntitlement llame a
|
||||
// notifyListeners() -- y como BannerAnuncioSuperior.build() hace
|
||||
// context.watch<EstadoEntitlement>(), cada notificación vuelve a
|
||||
// ejecutar didChangeDependencies() en este widget.
|
||||
compras.emitir(const EventoCompra(TipoEventoCompra.pendiente));
|
||||
await tester.pump();
|
||||
compras.emitir(const EventoCompra(TipoEventoCompra.cancelada));
|
||||
await tester.pump();
|
||||
compras.emitir(const EventoCompra(TipoEventoCompra.pendiente));
|
||||
await tester.pump();
|
||||
compras.emitir(const EventoCompra(TipoEventoCompra.error));
|
||||
await tester.pump();
|
||||
|
||||
expect(
|
||||
intentosDeCarga,
|
||||
1,
|
||||
reason:
|
||||
'cuatro notificaciones adicionales de EstadoEntitlement NO '
|
||||
'deben disparar cuatro cargas más -- solo la primera cuenta',
|
||||
);
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user