Extracts ServicioRadio's transport loop (server discovery, host rotation, bounded retries, User-Agent, timeout, status check, json.decode, sticky-host bookkeeping) out of `_get` into a new `_getJson(path, params) -> Future<List<dynamic>>` helper, moved as one block with no logic edits. `_get` is reimplemented on top, still owning every station-specific concern: `lastcheckok: '1'`, `Emisora.fromApi` + the empty-uuid/url filter, and the `_compararCalidad` quality sort. `_getJson` is deliberately sort-agnostic and filter-agnostic so a non-station endpoint can reuse the resilience behaviour without inheriting station-only semantics. Non-negotiable ordering followed per design ADR-4: new test/servicios/servicio_radio_transporte_test.dart characterises all 8 existing station calls (7 via `_get` plus `registrarClick`, which builds its own URI) against the UNMODIFIED `_get` first - green by construction - pinning path, lastcheckok=1, hidebroken=true, a non-empty User-Agent, exact order/reverse/limit/offset, and the exact returned UUID sequence from a fixture with deliberately shuffled bitrate/clickcount/votes. That last assertion is what makes the extraction safe: a sort that silently sank into transport would pass every other check. Re-running the same file after the extraction is byte-identical green. test/servicios/servicio_radio_test.dart is untouched by this work unit - its passing unmodified is itself a signal that transport wasn't disturbed. The 6 pre-existing `order: bitrate` occurrences (obtenerPopulares, buscarPorNombre, buscarPorPais, buscarPorIdioma, buscarPorTag, buscar) are untouched - a deliberate server-side quality bias deciding which stations return within `limit`, unrelated to and never to be confused with the user-facing "Ordenar" control, which stays entirely client-side via the existing OrdenEmisoras (Engram reference/radio-browser-sort-order). Behaviour delta, accepted per ADR-4, not a regression: moving `_servidorActual` bookkeeping into `_getJson` means a successful `/json/countries` call now warms the sticky host for subsequent station calls too - one shared warm mirror per instance, desirable, not per-call-type state. Adds the Paises browser over the verified `/json/countries` contract (Engram reference/radio-browser-countries-endpoint): new lib/modelos/pais_radio.dart (`PaisRadio.fromApi` parses `stationcount` via `int.tryParse` since the API returns it as a JSON string, not an int - an `as int` cast would throw), `obtenerPaises()` sends neither `lastcheckok` nor `order` (the screen sorts client-side by name; the API's raw byte order isn't proper collation for any locale this app ships), and inherits `hidebroken=true` from the unchanged `_uri` (desirable here too, since the endpoint's own default is false). `EstadoBusqueda` gains `paises`/`cargandoPaises`/`cargarPaises()` with an in-memory cache guard so re-entering the screen never refetches. New PantallaPaises (lib/pantallas/pantalla_paises.dart): a "Tus idiomas" shortlist (one representative country per the app's 13 supported locales, matched against the fetched list - the proposal/spec name this section but don't specify its derivation) above the full alphabetical list, each entry showing its parsed station count. Reachable from Buscar's discovery landing state via a new entry row, added now rather than left dangling per this file's own forward-reference comment (and the WU15/WU15b lesson: a fully-tested but unreachable screen is a real defect, not a follow-up). New ARB keys (en/es only, matching this change's established precedent): countriesScreenTitle, countriesYourLanguagesTitle, countriesAllTitle, radioCountriesError. Tests: 631 -> 649 (2 skipped, unchanged). flutter analyze unchanged at 1 pre-existing info. grep confirms `countrycodes` appears nowhere in lib/.
111 lines
4.1 KiB
Dart
111 lines
4.1 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pluriwave/estado/estado_busqueda.dart';
|
|
import 'package:pluriwave/l10n/gen/app_localizations.dart';
|
|
import 'package:pluriwave/modelos/pais_radio.dart';
|
|
import 'package:pluriwave/pantallas/pantalla_paises.dart';
|
|
import 'package:pluriwave/widgets/pluri_push_scaffold.dart';
|
|
import 'package:provider/provider.dart';
|
|
|
|
import '../helpers/fakes.dart';
|
|
|
|
/// WU7, `station-discovery-browse` spec — "Países Browser Over the Verified
|
|
/// Countries Contract": "Tus idiomas" shortlist + the full alphabetical
|
|
/// list, each entry showing its station count. `stationcount`'s "arrives as
|
|
/// a JSON string" edge case is covered at its own layer boundary in
|
|
/// `test/modelos/pais_radio_test.dart` — `FakeServicioRadio.obtenerPaises()`
|
|
/// returns already-parsed `PaisRadio` instances here, so this file tests
|
|
/// rendering only, not JSON parsing.
|
|
void main() {
|
|
Widget buildScreen(EstadoBusqueda estado) {
|
|
return ChangeNotifierProvider<EstadoBusqueda>.value(
|
|
value: estado,
|
|
child: MaterialApp(
|
|
locale: const Locale('es'),
|
|
localizationsDelegates: AppLocalizations.localizationsDelegates,
|
|
supportedLocales: AppLocalizations.supportedLocales,
|
|
home: const PantallaPaises(),
|
|
),
|
|
);
|
|
}
|
|
|
|
Future<void> pumpEstable(WidgetTester tester) async {
|
|
await tester.pump();
|
|
await tester.pumpAndSettle();
|
|
}
|
|
|
|
testWidgets(
|
|
'renders inside a PluriPushScaffold; muestra "Tus idiomas" y la lista '
|
|
'alfabética completa con el conteo de cada país',
|
|
(tester) async {
|
|
final estado = EstadoBusqueda(
|
|
radio: FakeServicioRadio(
|
|
paises: const [
|
|
PaisRadio(nombre: 'Spain', codigoIso: 'ES', numeroEmisoras: 482),
|
|
PaisRadio(
|
|
nombre: 'Argentina',
|
|
codigoIso: 'AR',
|
|
numeroEmisoras: 120,
|
|
),
|
|
PaisRadio(nombre: 'France', codigoIso: 'FR', numeroEmisoras: 75),
|
|
],
|
|
),
|
|
);
|
|
addTearDown(estado.dispose);
|
|
|
|
await tester.pumpWidget(buildScreen(estado));
|
|
await pumpEstable(tester);
|
|
|
|
expect(find.byType(PluriPushScaffold), findsOneWidget);
|
|
|
|
final l10n = AppLocalizations.of(
|
|
tester.element(find.byType(PantallaPaises)),
|
|
);
|
|
expect(find.text(l10n.countriesYourLanguagesTitle), findsOneWidget);
|
|
expect(find.text(l10n.countriesAllTitle), findsOneWidget);
|
|
|
|
// Full alphabetical list: all 3 fetched countries render.
|
|
expect(find.text('Argentina'), findsOneWidget);
|
|
expect(find.text('France'), findsOneWidget);
|
|
// 'Spain' renders twice: "Tus idiomas" (locale es -> representative
|
|
// country ES) AND the full list below.
|
|
expect(find.text('Spain'), findsWidgets);
|
|
|
|
// Each entry's parsed `stationcount` renders via the existing
|
|
// `stationsCount` string — 482 came from the API as a STRING
|
|
// (`PaisRadio.fromApi`'s job, verified separately) and must display
|
|
// as a plain number here, never throwing a cast error.
|
|
expect(find.text(l10n.stationsCount(482)), findsWidgets);
|
|
expect(find.text(l10n.stationsCount(120)), findsOneWidget);
|
|
expect(find.text(l10n.stationsCount(75)), findsOneWidget);
|
|
},
|
|
);
|
|
|
|
testWidgets(
|
|
'cargarPaises no se re-dispara si ya hay datos en caché al reconstruir',
|
|
(tester) async {
|
|
final radio = FakeServicioRadio(
|
|
paises: const [
|
|
PaisRadio(nombre: 'Italy', codigoIso: 'IT', numeroEmisoras: 30),
|
|
],
|
|
);
|
|
final estado = EstadoBusqueda(radio: radio);
|
|
addTearDown(estado.dispose);
|
|
|
|
await tester.pumpWidget(buildScreen(estado));
|
|
await pumpEstable(tester);
|
|
expect(radio.obtenerPaisesCalls, 1);
|
|
|
|
// Re-entering the screen (a fresh State, same EstadoBusqueda instance)
|
|
// must not refetch — the in-memory cache guard lives on EstadoBusqueda,
|
|
// not on the widget.
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
await pumpEstable(tester);
|
|
await tester.pumpWidget(buildScreen(estado));
|
|
await pumpEstable(tester);
|
|
|
|
expect(radio.obtenerPaisesCalls, 1);
|
|
},
|
|
);
|
|
}
|