Root-cause fix for the unstoppable-alarm incident (alarm rang 15 minutes, only uninstall silenced it) plus systematic hardening of every stop path. Native (Kotlin): - Verified stop: stopActiveAlarm now derives its result from the real post-teardown state (companion instance + synchronous stopEverything + activeRingingId check) instead of reporting unconditional success. - Atomic teardown: every stop path (stop action, notification button, snooze, missed, onDestroy, startForeground failure) funnels through one stopEverything() covering audio, wakelock, notification, foreground state and firing-record cleanup; player.release() guarded. - Bounded ringing: 10-minute auto-silence armed via AlarmManager fires a FIRED->MISSED transition with a localized missed-alarm notification; repeating alarms keep their native rearm, deleted alarms never produce ghost MISSED notifications. - Durable firing record with onStartCommand re-validation (resurrection guard) and boot-time stale cleanup; firing records cleared on every refuse/mismatch/cancel path. - New notification-only dismissal channel (dismissAlarmNotificationOnly) so UI-level dedup can never kill a live ring's audio. Flutter (Dart): - Stop/disable/edit/delete of a ringing alarm always attempt to silence it; on native-query failure the stop falls back toward silence via the id-scoped legacy stop. - Verified-stop results surface failures: the ringing screen keeps dismiss-by-design on success, but on a verified failure it stays up with a persistent force-stop banner (guarded against double-dismiss) and auto-dismisses if the ring ends externally (missed/notification). - Missed events sync alarm bookkeeping without opening the ringing UI. - 4 new l10n keys translated across all 13 locales (ARB guard green). 550 tests green, analyzer clean. Reviewed in 3 adversarial 4-lens rounds (2 deterministic + 1 refuter-corroborated critical fixed); formal gentle-ai receipt waived by maintainer authorization (correction scope legitimately exceeded the frozen genesis paths). On-device QA checklist in openspec/changes/alarm-system-overhaul/tasks.md pending before archive.
109 lines
3.5 KiB
Dart
109 lines
3.5 KiB
Dart
import 'dart:ui' show Locale;
|
|
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pluriwave/l10n/gen/app_localizations.dart';
|
|
import 'package:pluriwave/modelos/alarma_musical.dart';
|
|
import 'package:pluriwave/servicios/servicio_alarmas_android.dart';
|
|
|
|
void main() {
|
|
TestWidgetsFlutterBinding.ensureInitialized();
|
|
|
|
const channel = MethodChannel('pluriwave/alarm_scheduler');
|
|
late List<MethodCall> llamadas;
|
|
|
|
setUp(() {
|
|
llamadas = [];
|
|
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
|
|
.setMockMethodCallHandler(channel, (call) async {
|
|
llamadas.add(call);
|
|
if (call.method == 'scheduleAlarm') return true;
|
|
return null;
|
|
});
|
|
});
|
|
|
|
tearDown(() {
|
|
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
|
|
.setMockMethodCallHandler(channel, null);
|
|
});
|
|
|
|
test(
|
|
'configurarLocalizaciones pushes localized notification strings with {minutes} templates',
|
|
() async {
|
|
final servicio = ServicioAlarmasAndroid(channel: channel);
|
|
final l10n = lookupAppLocalizations(const Locale('es'));
|
|
|
|
servicio.configurarLocalizaciones(l10n);
|
|
// configurarLocalizaciones fires setNotificationStrings as unawaited; let
|
|
// the microtask/event queue drain so the MethodChannel call is recorded.
|
|
await Future<void>.delayed(Duration.zero);
|
|
|
|
final llamada = llamadas.singleWhere(
|
|
(c) => c.method == 'setNotificationStrings',
|
|
);
|
|
final args = llamada.arguments as Map<Object?, Object?>;
|
|
|
|
expect(
|
|
args['preNoticeTemplate'],
|
|
contains('{minutes}'),
|
|
reason: 'pre-notice template must keep the {minutes} placeholder',
|
|
);
|
|
expect(
|
|
args['snoozeCountdownTemplate'],
|
|
contains('{minutes}'),
|
|
reason: 'snooze countdown template must keep the {minutes} placeholder',
|
|
);
|
|
expect(
|
|
args['missedTemplate'],
|
|
contains('{name}'),
|
|
reason: 'missed template must keep the {name} placeholder',
|
|
);
|
|
|
|
// Every notification/channel/chooser string must be present and non-empty
|
|
// so the native side never falls back to English for a configured locale.
|
|
const claves = [
|
|
'ringTitle',
|
|
'snoozeLabel',
|
|
'stopLabel',
|
|
'skipLabel',
|
|
'snoozeAgainLabel',
|
|
'fireChannelName',
|
|
'fireChannelDescription',
|
|
'preNoticeChannelName',
|
|
'preNoticeChannelDescription',
|
|
'openFolderTitle',
|
|
'openRecordingTitle',
|
|
'missedTitle',
|
|
];
|
|
for (final clave in claves) {
|
|
expect(args[clave], isA<String>(), reason: '$clave missing');
|
|
expect(
|
|
(args[clave] as String).isNotEmpty,
|
|
isTrue,
|
|
reason: '$clave is empty',
|
|
);
|
|
}
|
|
},
|
|
);
|
|
|
|
test('scheduleAlarm no longer carries notification string templates', () async {
|
|
final servicio = ServicioAlarmasAndroid(channel: channel);
|
|
final alarma = AlarmaMusical(
|
|
id: 'no-template',
|
|
nombre: 'Alarm',
|
|
hora: 8,
|
|
minuto: 30,
|
|
tipoProgramacion: TipoProgramacionAlarma.diaria,
|
|
diasSemana: const [],
|
|
proximaEjecucion: DateTime(2099, 1, 2, 8, 30),
|
|
);
|
|
|
|
await servicio.programar(alarma);
|
|
|
|
final llamada = llamadas.singleWhere((c) => c.method == 'scheduleAlarm');
|
|
final args = llamada.arguments as Map<Object?, Object?>;
|
|
expect(args.containsKey('preNoticeTemplate'), isFalse);
|
|
expect(args.containsKey('snoozeCountdownTemplate'), isFalse);
|
|
});
|
|
}
|