Extracts ServicioRadio's transport loop (server discovery, host rotation, bounded retries, User-Agent, timeout, status check, json.decode, sticky-host bookkeeping) out of `_get` into a new `_getJson(path, params) -> Future<List<dynamic>>` helper, moved as one block with no logic edits. `_get` is reimplemented on top, still owning every station-specific concern: `lastcheckok: '1'`, `Emisora.fromApi` + the empty-uuid/url filter, and the `_compararCalidad` quality sort. `_getJson` is deliberately sort-agnostic and filter-agnostic so a non-station endpoint can reuse the resilience behaviour without inheriting station-only semantics. Non-negotiable ordering followed per design ADR-4: new test/servicios/servicio_radio_transporte_test.dart characterises all 8 existing station calls (7 via `_get` plus `registrarClick`, which builds its own URI) against the UNMODIFIED `_get` first - green by construction - pinning path, lastcheckok=1, hidebroken=true, a non-empty User-Agent, exact order/reverse/limit/offset, and the exact returned UUID sequence from a fixture with deliberately shuffled bitrate/clickcount/votes. That last assertion is what makes the extraction safe: a sort that silently sank into transport would pass every other check. Re-running the same file after the extraction is byte-identical green. test/servicios/servicio_radio_test.dart is untouched by this work unit - its passing unmodified is itself a signal that transport wasn't disturbed. The 6 pre-existing `order: bitrate` occurrences (obtenerPopulares, buscarPorNombre, buscarPorPais, buscarPorIdioma, buscarPorTag, buscar) are untouched - a deliberate server-side quality bias deciding which stations return within `limit`, unrelated to and never to be confused with the user-facing "Ordenar" control, which stays entirely client-side via the existing OrdenEmisoras (Engram reference/radio-browser-sort-order). Behaviour delta, accepted per ADR-4, not a regression: moving `_servidorActual` bookkeeping into `_getJson` means a successful `/json/countries` call now warms the sticky host for subsequent station calls too - one shared warm mirror per instance, desirable, not per-call-type state. Adds the Paises browser over the verified `/json/countries` contract (Engram reference/radio-browser-countries-endpoint): new lib/modelos/pais_radio.dart (`PaisRadio.fromApi` parses `stationcount` via `int.tryParse` since the API returns it as a JSON string, not an int - an `as int` cast would throw), `obtenerPaises()` sends neither `lastcheckok` nor `order` (the screen sorts client-side by name; the API's raw byte order isn't proper collation for any locale this app ships), and inherits `hidebroken=true` from the unchanged `_uri` (desirable here too, since the endpoint's own default is false). `EstadoBusqueda` gains `paises`/`cargandoPaises`/`cargarPaises()` with an in-memory cache guard so re-entering the screen never refetches. New PantallaPaises (lib/pantallas/pantalla_paises.dart): a "Tus idiomas" shortlist (one representative country per the app's 13 supported locales, matched against the fetched list - the proposal/spec name this section but don't specify its derivation) above the full alphabetical list, each entry showing its parsed station count. Reachable from Buscar's discovery landing state via a new entry row, added now rather than left dangling per this file's own forward-reference comment (and the WU15/WU15b lesson: a fully-tested but unreachable screen is a real defect, not a follow-up). New ARB keys (en/es only, matching this change's established precedent): countriesScreenTitle, countriesYourLanguagesTitle, countriesAllTitle, radioCountriesError. Tests: 631 -> 649 (2 skipped, unchanged). flutter analyze unchanged at 1 pre-existing info. grep confirms `countrycodes` appears nowhere in lib/.
61 lines
1.8 KiB
Dart
61 lines
1.8 KiB
Dart
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pluriwave/modelos/pais_radio.dart';
|
|
|
|
/// WU7 / `station-discovery-browse` spec, scenario "`stationcount` arrives
|
|
/// as a JSON string (edge case, critical)": the Radio Browser `/json/countries`
|
|
/// endpoint returns `stationcount` as a STRING, not a number. An `as int`
|
|
/// cast throws at runtime — this model MUST go through `int.tryParse`
|
|
/// (Engram `reference/radio-browser-countries-endpoint`, id 2500).
|
|
void main() {
|
|
group('PaisRadio.fromApi', () {
|
|
test('parsea stationcount desde un string JSON sin lanzar', () {
|
|
final pais = PaisRadio.fromApi(const {
|
|
'name': 'Spain',
|
|
'iso_3166_1': 'es',
|
|
'stationcount': '482',
|
|
});
|
|
|
|
expect(pais.nombre, 'Spain');
|
|
expect(pais.codigoIso, 'ES');
|
|
expect(pais.numeroEmisoras, 482);
|
|
});
|
|
|
|
test('normaliza iso_3166_1 a mayúsculas', () {
|
|
final pais = PaisRadio.fromApi(const {
|
|
'name': 'France',
|
|
'iso_3166_1': 'fr',
|
|
'stationcount': '10',
|
|
});
|
|
|
|
expect(pais.codigoIso, 'FR');
|
|
});
|
|
|
|
test('stationcount ausente cae a 0 sin lanzar', () {
|
|
final pais = PaisRadio.fromApi(const {
|
|
'name': 'Nowhere',
|
|
'iso_3166_1': 'xx',
|
|
});
|
|
|
|
expect(pais.numeroEmisoras, 0);
|
|
});
|
|
|
|
test('stationcount no numérico cae a 0 sin lanzar', () {
|
|
final pais = PaisRadio.fromApi(const {
|
|
'name': 'Nowhere',
|
|
'iso_3166_1': 'xx',
|
|
'stationcount': 'not-a-number',
|
|
});
|
|
|
|
expect(pais.numeroEmisoras, 0);
|
|
});
|
|
|
|
test('name/iso_3166_1 ausentes caen a string vacío sin lanzar', () {
|
|
final pais = PaisRadio.fromApi(const {'stationcount': '5'});
|
|
|
|
expect(pais.nombre, '');
|
|
expect(pais.codigoIso, '');
|
|
expect(pais.numeroEmisoras, 5);
|
|
});
|
|
});
|
|
}
|