fix(ajustes): show each settings row's current value

The prototype puts a trailing current-value string on nearly every settings row (t4 lines 512-539, 625 -- "3 guardados", "Alfabetico", "Espanol", "7 . 84 MB"). FilaAjuste only accepted icon/titulo/onTap, so every row was value-blind. Add an optional `valor` slot to FilaAjuste (13px, rgba(242,247,250,.55), rendered before the chevron). Wire 8 of the 12 built rows to state already available at the settings root: equalizer on/off, sleep-timer active, favourite-group count, preferred station name, custom-station count, sort order, recordings count-and-size (FutureBuilder over EstadoGrabacion.listarGrabaciones), and the current language (hoisted pantalla_ajustes_idioma.dart's native-name list to module level so the root can read it without duplicating it). Salida de audio, Musica local, Backup and Info's version are left without a value -- each lacks a low-risk, deterministically-testable data source (see the apply-progress note for the reason per row). Reading EstadoRadio for these values through a root `context.watch` would rebuild the whole settings list -- including the Grabaciones FutureBuilder's disk read -- on every unrelated audio notification; this follows the codebase's existing S4-R5 convention of narrow `context.select` per field instead. Ajustes' own PluriRootHeader/PluriScreenHeader edit (S2 in this same pass) landed in this commit too, since both touched the same header block in pantalla_ajustes.dart at the same time. S8, Tier 1 visual-fidelity pass (audit id 2521).
2026-07-29 21:26:48 +02:00
parent f5a211492a
commit e0164f68b5
5 changed files with 421 additions and 64 deletions
@@ -0,0 +1,52 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:pluriwave/pantallas/ajustes/widgets/fila_ajuste.dart';
+import 'package:pluriwave/tema/pluriwave_theme.dart';
+
+/// S8 (Tier 1 visual fidelity): the prototype puts a trailing "current
+/// value" on nearly every settings row, 13px `rgba(242,247,250,.55)` (t4
+/// lines 512-539, 625 — "Voz clara", "Alta", "3 guardados", "Alfabético",
+/// "7 · 84 MB", "Español", "Hoy, 08:12", "200 MB"). `FilaAjuste` used to
+/// accept only `icon`/`titulo`/`onTap` — no value slot at all.
+void main() {
+  Widget host(Widget child) {
+    return MaterialApp(
+      theme: PluriWaveTheme.dark(),
+      home: Scaffold(body: child),
+    );
+  }
+
+  testWidgets('renders the trailing value before the chevron when provided', (
+    tester,
+  ) async {
+    await tester.pumpWidget(
+      host(
+        FilaAjuste(
+          icon: Icons.language_rounded,
+          titulo: 'Language',
+          valor: 'English',
+          onTap: () {},
+        ),
+      ),
+    );
+
+    expect(find.text('English'), findsOneWidget);
+    expect(find.byIcon(Icons.chevron_right_rounded), findsOneWidget);
+  });
+
+  testWidgets('renders no trailing value text when valor is omitted '
+      '(unchanged pre-S8 behaviour)', (tester) async {
+    await tester.pumpWidget(
+      host(
+        FilaAjuste(
+          icon: Icons.info_outline_rounded,
+          titulo: 'Info',
+          onTap: () {},
+        ),
+      ),
+    );
+
+    expect(find.text('Info'), findsOneWidget);
+    expect(find.byIcon(Icons.chevron_right_rounded), findsOneWidget);
+  });
+}
@@ -0,0 +1,174 @@
+import 'dart:async';
+import 'dart:io';
+
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:pluriwave/estado/estado_ecualizador.dart';
+import 'package:pluriwave/estado/estado_grabacion.dart';
+import 'package:pluriwave/estado/estado_idioma.dart';
+import 'package:pluriwave/estado/estado_radio.dart';
+import 'package:pluriwave/l10n/gen/app_localizations.dart';
+import 'package:pluriwave/modelos/archivo_grabacion.dart';
+import 'package:pluriwave/pantallas/pantalla_ajustes.dart';
+import 'package:pluriwave/servicios/servicio_grabacion_radio.dart';
+import 'package:provider/provider.dart';
+import 'package:shared_preferences/shared_preferences.dart';
+
+import '../helpers/fakes.dart';
+
+/// S8 (Tier 1 visual fidelity): the prototype puts a trailing "current
+/// value" on nearly every settings row (t4 lines 512-539, 625 — e.g.
+/// "3 guardados", "Alfabético", "Español", "7 · 84 MB"). Wires 8 of the 12
+/// built rows to real, already-available state. The other 4 (Salida de
+/// audio, Música local, Backup, Info's version) are deliberately left
+/// without a value — see the apply-progress note for why each lacks a
+/// low-risk, deterministically-testable data source.
+///
+/// Pre-existing project constraint (see `pantalla_ajustes_test.dart`):
+/// PluriGlassSurface paints a background over ListTile's ink layer, which
+/// Flutter flags as a warning-level assertion, not a correctness bug.
+void _suppressListTileInkAssertion() {
+  final original = FlutterError.onError;
+  FlutterError.onError = (details) {
+    if (details.exceptionAsString().contains(
+      'ListTile background color or ink splashes may be invisible',
+    )) {
+      return;
+    }
+    original?.call(details);
+  };
+  addTearDown(() => FlutterError.onError = original);
+}
+
+/// Returns a fixed, in-memory recordings list — `listarGrabaciones()`'s real
+/// implementation touches the filesystem directly (`Directory.listSync`),
+/// which the project's own convention forbids exercising bare in a widget
+/// test.
+class _FakeServicioGrabacionConArchivos extends ServicioGrabacionRadio {
+  final _controller = StreamController<EstadoGrabacionRadio>.broadcast();
+
+  @override
+  EstadoGrabacionRadio get estado => const EstadoGrabacionRadio.inactiva();
+
+  @override
+  Stream<EstadoGrabacionRadio> get estadoStream => _controller.stream;
+
+  @override
+  Future<void> inicializar() async {}
+
+  @override
+  Future<List<ArchivoGrabacion>> listarGrabaciones() async => [
+    ArchivoGrabacion(
+      ruta: '/a.m4a',
+      nombre: 'a',
+      fecha: DateTime(2026, 1, 1),
+      tamanoBytes: 2 * 1024 * 1024,
+    ),
+    ArchivoGrabacion(
+      ruta: '/b.m4a',
+      nombre: 'b',
+      fecha: DateTime(2026, 1, 2),
+      tamanoBytes: 5 * 1024 * 1024,
+    ),
+  ];
+
+  @override
+  Future<void> dispose() => _controller.close();
+}
+
+void main() {
+  setUp(() {
+    SharedPreferences.setMockInitialValues({});
+  });
+
+  Future<File> archivoCustomVacio() async => File(
+    '${Directory.current.path}/test/fixtures/emisoras_custom_vacio.json',
+  );
+
+  void setLargeSurface(WidgetTester tester) {
+    tester.view.physicalSize = const Size(1440, 3200);
+    tester.view.devicePixelRatio = 1.0;
+    addTearDown(tester.view.resetPhysicalSize);
+    addTearDown(tester.view.resetDevicePixelRatio);
+  }
+
+  Future<void> pumpStable(WidgetTester tester) async {
+    await tester.pump();
+    await tester.pump(const Duration(milliseconds: 100));
+  }
+
+  Widget buildAjustes(EstadoRadio estado, EstadoIdioma idioma) {
+    return MultiProvider(
+      providers: [
+        ChangeNotifierProvider<EstadoRadio>.value(value: estado),
+        ListenableProvider<EstadoEcualizador>.value(value: estado.ecualizador),
+        ListenableProvider<EstadoGrabacion>.value(value: estado.grabacion),
+        ChangeNotifierProvider<EstadoIdioma>.value(value: idioma),
+      ],
+      child: MaterialApp(
+        locale: const Locale('en'),
+        localizationsDelegates: AppLocalizations.localizationsDelegates,
+        supportedLocales: AppLocalizations.supportedLocales,
+        home: const Scaffold(body: PantallaAjustes()),
+      ),
+    );
+  }
+
+  testWidgets('settings rows show their current value: EQ on, favourite groups '
+      'count, preferred station name, custom stations count, sort order, '
+      'recordings count · size, and the current language', (tester) async {
+    setLargeSurface(tester);
+    _suppressListTileInkAssertion();
+
+    final estado = EstadoRadio(
+      audio: FakeServicioAudio(),
+      favoritos: FakeServicioFavoritos(),
+      radio: FakeServicioRadio(),
+      servicioEcualizador: FakeServicioEcualizador(),
+      servicioGrabacion: _FakeServicioGrabacionConArchivos(),
+      resolverArchivoCustom: archivoCustomVacio,
+      iniciarAutomaticamente: false,
+    );
+    addTearDown(estado.dispose);
+    await estado.ecualizador.cargarPersistido();
+    await estado.ecualizador.cambiarActivo(true);
+
+    final favoritos = estado.favoritos as FakeServicioFavoritos;
+    await favoritos.crearGrupo('Rock');
+    await favoritos.crearGrupo('Jazz');
+    await estado.cargarGruposFavoritos();
+
+    final preferida = emisoraDemo(uuid: 'pref-1', nombre: 'Radio Horizonte');
+    await favoritos.agregar(preferida);
+    await estado.cargarFavoritos();
+    await estado.cambiarEmisoraPreferida(preferida);
+    await estado.ordenarFavoritos(OrdenEmisoras.calidad);
+
+    final idioma = EstadoIdioma();
+    // EstadoIdioma's constructor kicks off its own async `_cargar()` read
+    // from SharedPreferences; without waiting for it to settle first, it
+    // can resolve AFTER `seleccionarLocale` below and clobber the
+    // selection back to null (a real race, not a test flake). `tester.
+    // pump()`, NOT a bare `Future.delayed` — a real Timer/delay never
+    // fires inside `testWidgets`' fake-async zone without something
+    // driving fake time forward, and hangs the whole test.
+    await tester.pump();
+    await idioma.seleccionarLocale(const Locale('en'));
+
+    await tester.pumpWidget(buildAjustes(estado, idioma));
+    await pumpStable(tester);
+    // Lets the recordings FutureBuilder resolve.
+    await tester.pump();
+
+    final l10n = await AppLocalizations.delegate.load(const Locale('en'));
+
+    expect(find.text(l10n.equalizerActive), findsOneWidget);
+    // 3, not 2 — FakeServicioFavoritos seeds a protected "unassigned"
+    // group by default, on top of the 2 this test creates.
+    expect(find.text('3'), findsOneWidget); // favourite groups
+    expect(find.text('Radio Horizonte'), findsOneWidget);
+    expect(find.text(l10n.stationOrderByQuality), findsOneWidget);
+    expect(find.text('2 · 7 MB'), findsOneWidget);
+    expect(find.text('English'), findsOneWidget);
+  });
+}