refactor(ajustes): split remaining Settings sections into pushed screens

openspec/changes/rediseno-funcional/tasks.md

@@ -39,7 +39,7 @@
 | 1 | `feat(tokens): add design tokens, type scale, push scaffold, and root nav state` | — | 220-330 | Low | No |
 | 2 | `test(auto): confirm Android Auto tree matches the redesign, no code changes` | — | 0 | None | No |
 | 3a | `refactor(ajustes): split Settings AUDIO/EMISORAS into pushed detail screens` | 1 | ~~800-1000~~ → **REALIZED: 4,374** (2,760+ / 1,614-, 35 files) | High | **Yes — move-only diff** |
-| 3b | `refactor(ajustes): split remaining Settings sections into pushed screens` | 3a | **~2,500-3,200**\* | Medium-High | **Yes — move-only diff** |
+| 3b | `refactor(ajustes): split remaining Settings sections into pushed screens` | 3a | ~~2,500-3,200~~\* → **REALIZED: 2,190** (1,485+ / 705-, 28 files) | Medium-High | **Yes — move-only diff** |
 | 4 | `feat(favoritos): replace stacked group panels with chip-filtered reorderable list` | 1 | 300-400 | Medium | Monitor |
 | 5 | `feat(escuchar): replace discovery browser with embedded player and favorites grid` | 1, 4 | 350-450 | Medium | Monitor |
 | 6 | `feat(buscar): add discovery landing state, filter pills, counter, and sort` | 5 | 350-500 | Medium-High | Monitor |
@@ -66,9 +66,10 @@ WU3b moves 5 sections rather than 7 and needs no new shared widget (`fila_ajuste
 ~2,500-3,200. **Estimating lesson for every remaining work unit: a strict-TDD commit carries its test files, and any
 ARB touch drags 13 generated files with it. Estimates that count only `lib/` production code will read ~3-4x low.**
 
-**Root line count, for reference**: `pantalla_ajustes.dart` went 1,897 → **788** in WU3a. The "under 400 lines"
-success criterion is the WU3a+WU3b **combined** end state, not WU3a alone — WU3a owns only 7 of the 12 detail
-screens. WU3b must take the remaining ~388 lines out.
+**Root line count, for reference**: `pantalla_ajustes.dart` went 1,897 → 788 in WU3a → **198** in WU3b. The "under
+400 lines" success criterion was the WU3a+WU3b **combined** end state — WU3a owned only 7 of the 12 detail screens.
+WU3b converted the remaining 5 (Grabaciones, Música local, Idioma, Backup, Info) and the root is now exactly 4
+`GrupoAjustes` cards, well under the 400-line target.
 † Record `size:exception` at apply time only if the realized diff exceeds ~500 lines; justification: "largest single
 alarm-card + hero + vacation-summary restyle, not divisible without breaking the one-commit-per-work-unit rule."
 ‡ The proposal already isolates WU10 as "its own PR, never bundled" — splitting further would leave an unintegrated
@@ -226,23 +227,45 @@ modified. Do not attempt to slice under 450.
 Backup, Info)
 **Modified tests**: `test/pantallas/pantalla_ajustes_test.dart` (extended)
 
-- [ ] 3b.1 RED — extend detail-screen tests for the remaining 5 sections, asserting `PluriPushScaffold` usage and
-      preserved controls.
-- [ ] 3b.2 GREEN — cut `_SeccionGrabaciones` (92-291), `_SeccionMusicaLocal` (291-399) into
-      `pantalla_ajustes_grabaciones.dart`, `pantalla_ajustes_musica_local.dart`.
-- [ ] 3b.3 GREEN — cut `_SeccionIdioma` + `_IdiomaDisponible` (492-694), `_SeccionBackup` (1669-1791),
-      `_SeccionInfo` (1791-1896) into `pantalla_ajustes_idioma.dart`, `pantalla_ajustes_backup.dart`,
-      `pantalla_ajustes_info.dart`.
-- [ ] 3b.4 GREEN — in the root, replace the remaining sections with `FilaAjuste` rows under two more `GrupoAjustes`
-      cards (GRABACIONES Y MÚSICA, APLICACIÓN); confirm sleep timer and backup rows are present — corollary ruling,
-      nothing dropped.
-- [ ] 3b.5 REFACTOR — confirm `pantalla_ajustes.dart` now contains only 4 `GrupoAjustes` cards and is under 400
-      lines; delete now-unused private section widgets.
-- [ ] 3b.6 Verify — full `pantalla_ajustes_test.dart` suite green; all 12 detail screens present and reachable; no
-      service/state file touched.
+- [x] 3b.1 RED — extend detail-screen tests for the remaining 5 sections, asserting `PluriPushScaffold` usage and
+      preserved controls. **Applied against the CURRENT 788-line file (re-read fresh at apply time, not the stale
+      92-1896 line references below, which were computed against the pre-WU3a 1,897-line file).** Root test file:
+      removed the now-false "Sections pending WU3b remain inline" and "Phase 7" groups, added a `WU3b — GRABACIONES Y
+      MÚSICA and APLICACIÓN groups` group (5 scenarios: 2-row/3-row zero-inline-control checks, 2 push-navigation
+      checks, one "root is exactly 4 GrupoAjustes cards" check). The 2 relocated Phase-7 friendly-folder-name
+      scenarios moved verbatim into the new `ajustes/pantalla_ajustes_musica_local_test.dart`, targeting the isolated
+      pushed screen directly instead of scrolling to find it inside the whole root.
+- [x] 3b.2 GREEN — cut `_SeccionGrabaciones`, `_SeccionMusicaLocal` (Stateful) into `pantalla_ajustes_grabaciones.dart`,
+      `pantalla_ajustes_musica_local.dart` — verbatim, header row removed per the established rule.
+- [x] 3b.3 GREEN — cut `_SeccionIdioma` + `_IdiomaDisponible`, `_SeccionBackup`, `_SeccionInfo` into
+      `pantalla_ajustes_idioma.dart`, `pantalla_ajustes_backup.dart`, `pantalla_ajustes_info.dart`. **Correction
+      found at apply time**: unlike the other 4 sections, `_SeccionInfo` never had its own header icon+title row —
+      its first tile (app name + version) already served that role — so there was no header to strip for that one
+      screen; its body moved in full, unchanged. This is also why `infoSectionTitle` is a genuinely new ARB key (no
+      existing in-body header string covered a bare "Info" label), unlike the other 4 screens which all reuse
+      pre-existing strings.
+- [x] 3b.4 GREEN — in the root, replaced the remaining 5 sections with `FilaAjuste` rows under two more
+      `GrupoAjustes` cards: RECORDINGS & MUSIC (Recordings, Local music) and APPLICATION (Language, Backup, Info).
+      Confirmed sleep timer (WU3a) and backup/restore (this WU) rows are both present — corollary ruling, nothing
+      dropped. **3 new ARB keys** (en/es only, matching WU1/WU3a's precedent of leaving the other 11 locales for
+      WU18): `settingsGroupRecordingsTitle` ("RECORDINGS & MUSIC"/"GRABACIONES Y MÚSICA"),
+      `settingsGroupApplicationTitle` ("APPLICATION"/"APLICACIÓN") for the two new group eyebrow labels, and
+      `infoSectionTitle` ("Info"/"Información") for the one row with no pre-existing header string (see 3b.3). All
+      other row titles reuse existing ARB keys.
+- [x] 3b.5 REFACTOR — confirmed `pantalla_ajustes.dart` now contains exactly 4 `GrupoAjustes` cards and is **198
+      lines** (well under the 400-line target); deleted all 5 now-unused private section widgets plus every import
+      that was only needed by their bodies (`dart:async`, `dart:io`, `file_picker`, `package_info_plus`,
+      `path_provider`, `provider`, `share_plus`, `estado_grabacion.dart`, `estado_idioma.dart`, `estado_radio.dart`,
+      `musica_local_auto.dart`, `pluri_glass_surface.dart`, `pluri_onboarding_dialog.dart` — none of these are read
+      by the root anymore since it is pure navigation chrome).
+- [x] 3b.6 Verify — scoped suite (`pantalla_ajustes_test.dart` + `ajustes/`) green: 45/45. All 12 detail screens
+      present and reachable. `git diff` touches only screen/test/ARB(+generated l10n) files — no service/state file
+      touched. Full suite: 592/592 (up from 579). `flutter analyze`: 1 issue, identical to baseline.
 
-**`size:exception` — "move-only diff".** ~500-700 changed lines (derived; see forecast table footnote). Same
-justification as WU3a.
+**`size:exception` — "move-only diff".** Realized: **2,190 changed lines** (1,485+ / 705-) across 28 files — under
+the ~2,500-3,200 estimate this time (Música local's compact Stateful body and this batch's conservative choice to
+verify reachability rather than tap through unmocked native-channel controls for Backup/Grabaciones' riskiest rows
+both kept it below forecast). Same "move-only diff" justification as WU3a.
 
 ## WU4 — Favoritos restyle