fix(alarmas,auto): guard the last unguarded snooze path, surface car progress
Continuation of7054a4c: the native anchor guard alone did not fix the reported ~1444-minute snooze, because Dart runs AFTERWARDS on the pre-notice path and had no guard at all. 1. Snooze from the pre-notice notification, root cause. app.dart dispatches AFTER the receiver's postponeNext already ran and after startActivity, and EstadoAlarmas.posponerProximaDesdePreaviso took whatever occurrence it was handed on faith, then persisted and rescheduled from it -- the last snooze path in the codebase with no occurrence guard. The occurrence itself is not trustworthy either: app.dart falls back to alarma.proximaEjecucion when the native event carries none, and that field can already point at tomorrow. _ocurrenciaSonando is generalized into _ocurrenciaValida with a caller- supplied forward allowance and an externally-proposed occurrence that still has to survive the same check. The pre-notice path gets a ventanaPreaviso (30 min, matching AlarmScheduler.PRE_NOTICE_MILLIS) -- unlike the ringing-screen guard, this occurrence legitimately has not happened yet, which is exactly why the existing helper could not just be reused here. Also heals state already poisoned by the missing guard: a snoozeHasta parked past a 3-hour ceiling (posponerEjecucion clamps to 120 minutes, so anything beyond that is corruption, not a long real snooze) is dropped on recalculation. Without it, an alarm poisoned on a build before this fix keeps reporting tomorrow after updating, and the user reasonably concludes nothing changed. 2. Android Auto: no progress bar or time labels on a local track. updatePosition was never set anywhere in the handler, so it sat at its Duration.zero default while copyWith refreshed updateTime to now on every push -- the car was told "position 0, as of right now" on every event, a bar pinned at the start regardless of what was actually playing. Now set from _player.position on both the player-state and buffered-position listeners (the latter ticks ~2/s, which is what keeps the car's bar smooth between player-state events). Also stream the MediaItem's duration once the source reports it -- Auto draws no bar at all without one, and radio streams correctly keep reporting none (live audio has no length). 3. Android Auto: drop the Ecualizador browsable folder. Owner decision after driving with it: a browsable six-preset list is more interaction than a driver wants, and on/off from all three player views (already fixed in7054a4cto win the custom-action slot) is the only equalizer control that belongs in the car. Preset selection stays on the phone. This lands back on the redesign mockup's original rule ("sin carpeta de ecualizador"), now for a road-tested reason. getChildren keeps answering the folder's id transitionally, since a head unit can have the old tree cached for a session or two. The two "raiz always includes/ends with Ecualizador" tests are replaced, not regressed -- same move the codebase already made once in the other direction for the same folder. Tests: 1127 -> 1132.
This commit is contained in:
@@ -564,8 +564,22 @@ class ServicioAlarmas {
|
||||
final ahora = _reloj();
|
||||
// S2-R5: a disabled alarm must not keep a pending snooze; clearing it
|
||||
// here guarantees the snoozed occurrence dies with the alarm.
|
||||
// Self-heal for a snooze target parked absurdly far out — the reported
|
||||
// "posponer left it 1400+ minutes away". A legitimate snooze can never
|
||||
// reach here: posponerEjecucion clamps to `minutos.clamp(1, 120)` and the
|
||||
// anchor is now guarded on both the native and Dart sides, so anything
|
||||
// past that ceiling is a leftover from a build that had neither guard.
|
||||
// Without this, an alarm poisoned before the fix keeps showing tomorrow
|
||||
// on every tick — the user reinstalls, sees no change, and reasonably
|
||||
// concludes nothing was fixed. Generous margin over the 120-minute cap so
|
||||
// a real long snooze is never mistaken for corruption.
|
||||
const techoSnooze = Duration(hours: 3);
|
||||
final snoozeCorrupto =
|
||||
alarma.snoozeHasta != null &&
|
||||
alarma.snoozeHasta!.isAfter(ahora.add(techoSnooze));
|
||||
final snoozeActivo =
|
||||
alarma.activa &&
|
||||
!snoozeCorrupto &&
|
||||
alarma.snoozeHasta != null &&
|
||||
alarma.snoozeHasta!.isAfter(ahora);
|
||||
// Self-heal for state poisoned before the Detener anchor fix: a stop
|
||||
|
||||
Reference in New Issue
Block a user