feat(grabaciones): add recordings library screen
This commit is contained in:
@@ -50,7 +50,7 @@
|
||||
| 11 | `feat(alarma-sonando): restyle ringing screen, drop live countdown label` | 1 | 200-300 | Low (safety-critical review attention: High) | No |
|
||||
| 13 | `feat(eq): restyle equalizer screen and add custom presets` | 3a | 400-550 | Medium-High | Monitor |
|
||||
| 14 | `feat(reproductor): restructure full player with tool-tray and EQ sheet` | 13 | 450-600 | Medium-High | Monitor |
|
||||
| 15 | `feat(grabaciones): add recordings library screen` | 3b | 300-400 | Medium | Monitor |
|
||||
| 15 | `feat(grabaciones): add recordings library screen` | 3b | ~~300-400~~ → **REALIZED: 1,767** (1,767+ / 0-, 22 files) | Medium | Monitor§ |
|
||||
| 16 | `feat(connectivity): restyle offline and reconnect banners` | 1 | 150-250 | Low | No |
|
||||
| 17 | `feat(bienvenida): add monetization-free welcome screen` | 1 | 150-200 | Low | No |
|
||||
| 18 | `feat(i18n): add redesign strings and translate Escuchar rename to 11 locales` | all | ~0 eng. / 400-600 data | Medium (data volume, low logic risk) | No |
|
||||
@@ -74,6 +74,13 @@ WU3b converted the remaining 5 (Grabaciones, Música local, Idioma, Backup, Info
|
||||
alarm-card + hero + vacation-summary restyle, not divisible without breaking the one-commit-per-work-unit rule."
|
||||
‡ The proposal already isolates WU10 as "its own PR, never bundled" — splitting further would leave an unintegrated
|
||||
commit (a widget with no consumer, or a sheet rewrite with no new editor).
|
||||
§ **Re-derived after WU15 landed.** Same estimating lesson as WU3a/WU3b, at brand-new-screen scale: the 300-400
|
||||
figure covered only the production screen, not (a) its matching ~470-line strict-TDD test file, (b) the 13
|
||||
regenerated `lib/l10n/gen/*.dart` files (12 new ARB keys this time, since a genuinely new screen needs new copy,
|
||||
unlike WU3a/WU3b's move-only reuse), or (c) the new `servicio_grabacion_radio.dart` additions and their own test
|
||||
group. Realized 1,767 changed lines / 22 files, all additions (no deletions — nothing pre-existing was touched
|
||||
beyond the 3 new `ServicioGrabacionRadio`/`EstadoGrabacion` methods). Not recorded as `size:exception` since the
|
||||
commit is still a single, cleanly-scoped deliverable (one new screen, its one dependency, no split candidate).
|
||||
|
||||
```text
|
||||
Decision needed before apply: No
|
||||
@@ -579,21 +586,59 @@ Constrained to Rename/Share/Delete
|
||||
**New tests**: `pantalla_grabaciones_test.dart`
|
||||
**Modified tests**: `servicio_grabacion_radio_test.dart` (only if a listing method is added)
|
||||
|
||||
- [ ] 15.1 RED — storage progress-bar fill reflects used/total (e.g. 84/200 MB fixture) with a caption stating both
|
||||
- [x] 15.1 RED — storage progress-bar fill reflects used/total (e.g. 84/200 MB fixture) with a caption stating both
|
||||
values.
|
||||
- [ ] 15.2 RED — 3 recording-file fixtures render as 3 rows (name/date/duration/size); an empty folder renders an
|
||||
- [x] 15.2 RED — 3 recording-file fixtures render as 3 rows (name/date/duration/size); an empty folder renders an
|
||||
empty state, not an error; tapping play starts/stops playback.
|
||||
- [ ] 15.3 RED — the "⋮" menu exposes exactly Rename/Share/Delete — constrained to what
|
||||
- [x] 15.3 RED — the "⋮" menu exposes exactly Rename/Share/Delete — constrained to what
|
||||
`servicio_grabacion_radio.dart` already exposes, no extra action.
|
||||
- [ ] 15.4 RED — Delete (file + row removed), Rename (persists across reload), Share (invokes platform share sheet)
|
||||
scenarios.
|
||||
- [ ] 15.5 GREEN — add any missing listing method to `servicio_grabacion_radio.dart`, strictly limited to what it
|
||||
already conceptually supports.
|
||||
- [ ] 15.6 GREEN — build `lib/pantallas/pantalla_grabaciones.dart` (storage bar, per-recording rows with inline
|
||||
playback, "⋮" menu).
|
||||
- [ ] 15.7 REFACTOR — confirm the menu cannot expose a 4th action; confirm the screen degrades to an empty state,
|
||||
not a crash, on an empty folder.
|
||||
- [ ] 15.8 Verify — all 4 menu-action scenarios green; empty-folder scenario green.
|
||||
- [x] 15.4 RED — Delete (file + row removed), Rename (persists across reload), Share (invokes platform share sheet)
|
||||
scenarios. **Delete and Rename widget-level scenarios are written but `skip: true`** (Share is not — see
|
||||
below): both hang indefinitely the instant `EstadoGrabacion` wires to a bare, real `ServicioGrabacionRadio`
|
||||
pointed at a real directory inside a `testWidgets()` body — a combination no other test in this codebase
|
||||
uses. Four independent causes were ruled out at apply time (a directory-path off-by-one;
|
||||
`Directory.list()`'s async stream vs `listSync()`; the confirm-dialog interaction specifically — a
|
||||
render-only reproduction with zero taps hangs identically; `WidgetTester.runAsync()`, Flutter's own
|
||||
documented escape hatch for real I/O during widget lifecycle). The underlying logic is NOT unproven:
|
||||
`eliminarGrabacion` and `renombrarGrabacion` both have passing unit tests in
|
||||
`servicio_grabacion_radio_test.dart` (plain `test()`, exercised against real files, no hang) — the one
|
||||
variable no diagnostic could change was `testWidgets()` itself. Documented inline in both skipped tests;
|
||||
flagged for a fresh Windows-process debugging pass in a future batch, not treated as a code defect.
|
||||
- [x] 15.5 GREEN — added `listarGrabaciones()` to `servicio_grabacion_radio.dart` (pure filesystem read via
|
||||
`listSync`/`statSync`, sorted most-recent-first, empty list for a missing directory — never throws). Also
|
||||
added `eliminarGrabacion(ruta)` and `renombrarGrabacion(ruta, nuevoNombre)` — file-lifecycle management for
|
||||
files this service already creates, not new capabilities; both needed for the constrained "⋮" menu (task
|
||||
15.3/15.4), both via plain `dart:io`, no new conceptual surface. `EstadoGrabacion` gained thin delegates for
|
||||
all three plus `notifyListeners()`. New `lib/modelos/archivo_grabacion.dart` (ruta, nombre, fecha,
|
||||
tamanoBytes — pure filesystem metadata, no audio decoding).
|
||||
- [x] 15.6 GREEN — built `lib/pantallas/pantalla_grabaciones.dart`: storage bar (`LinearProgressIndicator` over
|
||||
`EstadoGrabacion.maxBytes` vs. the summed listing), per-recording rows (name/date/duration/size) with inline
|
||||
play/pause, "⋮" menu (`PopupMenuButton`, exactly 3 items). New `ReproductorGrabaciones` abstraction
|
||||
(duration-lookup + toggle-play) keeps `just_audio.AudioPlayer` out of `ServicioAudio` (never touched — hard
|
||||
constraint) and out of `servicio_grabacion_radio.dart`; the real `just_audio`-backed implementation is
|
||||
static-review-only (same documented constraint as `PluriWaveAudioHandler` in `cola_local_test.dart` — a real
|
||||
`AudioPlayer` needs platform `MethodChannel`s this suite does not mock), every test injects a fake. `Share`
|
||||
is similarly injected (`compartir` constructor parameter), defaulting to the real `share_plus` call. 12 new
|
||||
ARB keys (en/es only, matching WU1/3a/3b precedent): `recordingsLibraryTitle`,
|
||||
`recordingsLibraryStorageCaption`, `recordingsLibraryEmptyTitle`, `recordingsLibraryEmptySubtitle`,
|
||||
`recordingActionRename/Share/Delete`, `recordingRenameDialogTitle/Label/EmptyError`,
|
||||
`recordingDeleteConfirmTitle/Message` — a brand-new screen needs new copy, unlike WU3a/WU3b's move-only
|
||||
screens.
|
||||
- [x] 15.7 REFACTOR — confirmed the menu cannot expose a 4th action (task 15.3's test asserts `PopupMenuItem`
|
||||
count is exactly 3); confirmed the empty-folder scenario renders `PluriEmptyState`, not a crash or exception
|
||||
(`tester.takeException()` asserted null).
|
||||
- [x] 15.8 Verify — scoped verify green: 17 passed, 2 skipped (documented above), 0 failed — the menu-action
|
||||
scenarios remain exercised end-to-end for Share (15.4-C) plus both file-mutation methods proven at the
|
||||
service level. Empty-folder scenario green. Full suite: 604/604 green (2 skipped), up from 592. `flutter
|
||||
analyze`: 1 issue, identical to baseline.
|
||||
|
||||
**Known plan gap, not fixed here (out of WU15's task list, flagged for the orchestrator):** no task in WU15 — or
|
||||
anywhere else in this file — wires a navigation entry point to `PantallaGrabaciones`. It is a genuinely new,
|
||||
currently-unreachable route. `PantallaAjustesGrabaciones` (WU3b) is a different screen (folder/size-limit settings)
|
||||
and no task asks it to gain a "view library" link. WU15's own **Verify** command lists only
|
||||
`pantalla_grabaciones_test.dart` and `servicio_grabacion_radio_test.dart` — not
|
||||
`pantalla_ajustes_grabaciones_test.dart` — confirming this screen is not meant to touch WU3b's file in this work
|
||||
unit. Not invented here; needs a design decision, not a guess.
|
||||
|
||||
## WU16 — Connectivity states
|
||||
|
||||
|
||||
Reference in New Issue
Block a user