fix(alarm): fail-safe alarm system overhaul (SDD alarm-system-overhaul, slice A)
Build & Deploy PluriWave / Análisis de código (push) Successful in 25s
Build & Deploy PluriWave / Build APK + AAB release (push) Successful in 2m25s

Root-cause fix for the unstoppable-alarm incident (alarm rang 15 minutes,
only uninstall silenced it) plus systematic hardening of every stop path.

Native (Kotlin):
- Verified stop: stopActiveAlarm now derives its result from the real
  post-teardown state (companion instance + synchronous stopEverything +
  activeRingingId check) instead of reporting unconditional success.
- Atomic teardown: every stop path (stop action, notification button,
  snooze, missed, onDestroy, startForeground failure) funnels through one
  stopEverything() covering audio, wakelock, notification, foreground
  state and firing-record cleanup; player.release() guarded.
- Bounded ringing: 10-minute auto-silence armed via AlarmManager fires a
  FIRED->MISSED transition with a localized missed-alarm notification;
  repeating alarms keep their native rearm, deleted alarms never produce
  ghost MISSED notifications.
- Durable firing record with onStartCommand re-validation (resurrection
  guard) and boot-time stale cleanup; firing records cleared on every
  refuse/mismatch/cancel path.
- New notification-only dismissal channel (dismissAlarmNotificationOnly)
  so UI-level dedup can never kill a live ring's audio.

Flutter (Dart):
- Stop/disable/edit/delete of a ringing alarm always attempt to silence
  it; on native-query failure the stop falls back toward silence via the
  id-scoped legacy stop.
- Verified-stop results surface failures: the ringing screen keeps
  dismiss-by-design on success, but on a verified failure it stays up
  with a persistent force-stop banner (guarded against double-dismiss)
  and auto-dismisses if the ring ends externally (missed/notification).
- Missed events sync alarm bookkeeping without opening the ringing UI.
- 4 new l10n keys translated across all 13 locales (ARB guard green).

550 tests green, analyzer clean. Reviewed in 3 adversarial 4-lens rounds
(2 deterministic + 1 refuter-corroborated critical fixed); formal
gentle-ai receipt waived by maintainer authorization (correction scope
legitimately exceeded the frozen genesis paths). On-device QA checklist
in openspec/changes/alarm-system-overhaul/tasks.md pending before
archive.
This commit is contained in:
Javier Bautista Fernández
2026-07-22 23:52:36 +02:00
parent 0f9a6a1719
commit 29f7d54e85
50 changed files with 2461 additions and 24 deletions
@@ -20,6 +20,10 @@ void main() {
return true;
case 'requestIgnoreBatteryOptimizations':
return true;
case 'getActiveRingingAlarmId':
return 'ring1';
case 'stopActiveAlarm':
return {'stopped': true, 'wasRinging': true, 'activeAlarmId': 'ring1'};
}
return null;
});
@@ -107,4 +111,54 @@ void main() {
},
);
test(
'detenerSonidoActivo mapea el resultado nativo confirmado a ResultadoDetencion',
() async {
final servicio = ServicioAlarmasAndroid(channel: channel);
final resultado = await servicio.detenerSonidoActivo();
final sonando = await servicio.alarmaSonandoId();
expect(resultado.detenido, isTrue);
expect(resultado.estabaSonando, isTrue);
expect(resultado.alarmaId, 'ring1');
expect(sonando, 'ring1');
},
);
test(
'detenerSonidoActivo retorna un resultado fallido cuando el canal lanza error',
() async {
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
.setMockMethodCallHandler(channel, (call) async {
llamadas.add(call);
throw PlatformException(code: 'STOP_FAILED', message: 'boom');
});
final servicio = ServicioAlarmasAndroid(channel: channel);
final resultado = await servicio.detenerSonidoActivo();
expect(resultado.detenido, isFalse);
expect(resultado.estabaSonando, isFalse);
expect(resultado.alarmaId, isNull);
},
);
test(
'alarmaSonandoId propaga el error del canal (fail-toward-silence, '
'Finding 2)',
() async {
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
.setMockMethodCallHandler(channel, (call) async {
llamadas.add(call);
throw PlatformException(code: 'QUERY_FAILED', message: 'boom');
});
final servicio = ServicioAlarmasAndroid(channel: channel);
expect(
() => servicio.alarmaSonandoId(),
throwsA(isA<PlatformException>()),
);
},
);
}
@@ -53,6 +53,11 @@ void main() {
contains('{minutes}'),
reason: 'snooze countdown template must keep the {minutes} placeholder',
);
expect(
args['missedTemplate'],
contains('{name}'),
reason: 'missed template must keep the {name} placeholder',
);
// Every notification/channel/chooser string must be present and non-empty
// so the native side never falls back to English for a configured locale.
@@ -68,6 +73,7 @@ void main() {
'preNoticeChannelDescription',
'openFolderTitle',
'openRecordingTitle',
'missedTitle',
];
for (final clave in claves) {
expect(args[clave], isA<String>(), reason: '$clave missing');